linux-kernel - Re: [PATCH 1/2] input: mt: Support separate contact and finger count reports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 12 Dec 2010 18:34:31 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Henrik Rydberg <rydberg@...omail.se>
Cc:	Jiri Kosina <jkosina@...e.cz>, Ping Cheng <pingc@...om.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] input: mt: Support separate contact and finger count
 reports

On Sat, Dec 11, 2010 at 11:28:27AM +0100, Henrik Rydberg wrote:
> A number of old and semi-recent touch devices are capable of counting
> the number of fingers on the pad within being able to give details for
> all individual contacts. This patch simplifies reporting for such
> hardware by providing a separate function for finger count.
> 

Looks good, just a couple nits below.

>  
>  /**
> + * input_mt_report_finger_count() - report contact count via buttons

"via buttons" is awkward, I'd simply dropped it,

> + * @dev: input device with allocated MT slots
> + * @count: the number of contacts
> + *
> + * Reports the contact count via BTN_TOOL_FINGER, BTN_TOOL_DOUBLETAP,
> + * BTN_TOOL_TRIPLETAP and BTN_TOOL_QUADTAP.
> + *
> + * The input core ensures only the KEY axes already setup for

s/axes/events/ ?

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/