linux-kernel - Re: [PATCH] aio: check return value of create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 13 Dec 2010 10:58:08 -0500
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Namhyung Kim <namhyung@...il.com>
Cc:	Benjamin LaHaise <bcrl@...ck.org>,
	Alexander Viro <viro@...iv.linux.org.uk>, linux-aio@...ck.org,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] aio: check return value of create_workqueue()

Namhyung Kim <namhyung@...il.com> writes:

> Signed-off-by: Namhyung Kim <namhyung@...il.com>
> ---
>  fs/aio.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/aio.c b/fs/aio.c
> index 8c8f6c5b6d79..c56153f5f73e 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -87,7 +87,7 @@ static int __init aio_setup(void)
>  
>  	aio_wq = create_workqueue("aio");
>  	abe_pool = mempool_create_kmalloc_pool(1, sizeof(struct aio_batch_entry));
> -	BUG_ON(!abe_pool);
> +	BUG_ON(!aio_wq || !abe_pool);
>  
>  	pr_debug("aio_setup: sizeof(struct page) = %d\n", (int)sizeof(struct page));

Acked-by: Jeff Moyer <jmoyer@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/