linux-kernel - Re: linux-next: Tree for December 16 (broken iwlwifi)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 16 Dec 2010 12:16:21 +0100
From:	Sedat Dilek <sedat.dilek@...glemail.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>,
	John Linville <linville@...driver.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	wireless <linux-wireless@...r.kernel.org>,
	Johannes Berg <johannes.berg@...el.com>,
	Wey-Yi Guy <wey-yi.w.guy@...el.com>,
	Randy Dunlap <randy.dunlap@...cle.com>
Subject: Re: linux-next: Tree for December 16 (broken iwlwifi)

On Thu, Dec 16, 2010 at 12:05 PM, Sedat Dilek
<sedat.dilek@...glemail.com> wrote:
> On Thu, Dec 16, 2010 at 11:54 AM, Sedat Dilek
> <sedat.dilek@...glemail.com> wrote:
>> Hi,
>>
>> Just FYI (didn't look at the code right now, sorry for German output):
>>
>> [ build.log ]
>> ...
>> /home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/source_i386_none/drivers/net/wireless/iwlwifi/iwl-agn-rs.c:
>> In function ‘iwl_rs_rate_init’:
>> /home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/source_i386_none/drivers/net/wireless/iwlwifi/iwl-agn-rs.c:2876:8:
>> error: ‘struct iwl_lq_sta’ has no member named ‘dbg_fixed_rate’
>> make[8]: *** [drivers/net/wireless/iwlwifi/iwl-agn-rs.o] Fehler 1
>> make[7]: *** [drivers/net/wireless/iwlwifi] Fehler 2
>> make[6]: *** [drivers/net/wireless] Fehler 2
>> make[6]: *** Warte auf noch nicht beendete Prozesse...
>> ...
>>
>> Regards,
>> - Sedat -
>>
>
> Looks like dbg_fixed_rate is only set when CONFIG_MAC80211_DEBUGFS is set:
>
> [ drivers/net/wireless/iwlwifi/iwl-agn-rs.h ]
> ...
> #ifdef CONFIG_MAC80211_DEBUGFS
>        struct dentry *rs_sta_dbgfs_scale_table_file;
>        struct dentry *rs_sta_dbgfs_stats_table_file;
>        struct dentry *rs_sta_dbgfs_rate_scale_data_file;
>        struct dentry *rs_sta_dbgfs_tx_agg_tid_en_file;
>        u32 dbg_fixed_rate;
> #endif
> ...
>
> So I have no CONFIG_MAC80211_DEBUGFS... :-).
> Can someone fix that, please?
>
> - Sedat -
>

Untested !

----- SNIP -----

diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-rs.c
b/drivers/net/wireless/iwlwifi/iwl-agn-rs.c
index 5083dba..75fcd30 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-rs.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-rs.c
@@ -2873,7 +2873,9 @@ void iwl_rs_rate_init(struct iwl_priv *priv,
struct ieee80211_sta *sta, u8 sta_i
                lq_sta->last_txrate_idx += IWL_FIRST_OFDM_RATE;
        lq_sta->is_agg = 0;

+#ifdef CONFIG_MAC80211_DEBUGFS
        lq_sta->dbg_fixed_rate = 0;
+#endif

        rs_initialize_lq(priv, conf, sta, lq_sta);
 }

----- SNAP -----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/