linux-kernel - Re: [PATCH 3/3] spi: mpc512x_psc_spi: move probe-routine to _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Dec 2010 10:27:22 -0700
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	devicetree-discuss@...abs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] spi: mpc512x_psc_spi: move probe-routine to __init

On Thu, Dec 16, 2010 at 10:13 AM, Wolfram Sang <w.sang@...gutronix.de> wrote:
> Since of_probe_platform_driver(), this SoC-device can be moved from
> __devinit to __init because it is not hotpluggable.
>
> Signed-off-by: Wolfram Sang <w.sang@...gutronix.de>

I really wouldn't bother.  You're counting pennies when the kernel
uses upwards of 4 megabytes for .text alone, and I don't like fiddling
with the driver model the way platform_bus_probe() does.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/