linux-kernel - RE: [PATCH] mfd: tps6586x: Remove device ID check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Dec 2010 12:35:17 -0800
From:	Stephen Warren <swarren@...dia.com>
To:	"sameo@...ux.intel.com" <sameo@...ux.intel.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"achew@...dai.com" <achew@...dai.com>,
	"olofj@...omium.org" <olofj@...omium.org>
Subject: RE: [PATCH] mfd: tps6586x: Remove device ID check

> From: Stephen Warren [mailto:swarren@...dia.com]
> Sent: Thursday, December 09, 2010 10:30 AM
> 
> ... and convert it to a dev_info print at probe time.

Samuel,

Sorry to ping you, but does this updated patch look OK and address your
concerns? Thanks.

> There are many variants of this chip with different values of VERSIONCRC.
> The set of values is large, and not useful to enumerate. All are SW
> compatible. The difference lies in default settings of the various power
> rails, and other similar differences. The driver, or clients of the
> driver, shouldn't be affected by this, since all rails should be
> programmed into the desired state in all cases for correct operation.
> 
> Derived-from-code-by: Andrew Chew <achew@...dia.com>
> Signed-off-by: Stephen Warren <swarren@...dia.com>
> ---
>  drivers/mfd/tps6586x.c |    8 +-------
>  1 files changed, 1 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c
> index b4931ab..3575739 100644
> --- a/drivers/mfd/tps6586x.c
> +++ b/drivers/mfd/tps6586x.c
> @@ -46,8 +46,6 @@
> 
>  /* device id */
>  #define TPS6586X_VERSIONCRC	0xcd
> -#define TPS658621A_VERSIONCRC	0x15
> -#define TPS658621C_VERSIONCRC	0x2c
> 
>  struct tps6586x_irq_data {
>  	u8	mask_reg;
> @@ -498,11 +496,7 @@ static int __devinit tps6586x_i2c_probe(struct i2c_client *client,
>  		return -EIO;
>  	}
> 
> -	if ((ret != TPS658621A_VERSIONCRC) &&
> -	    (ret != TPS658621C_VERSIONCRC)) {
> -		dev_err(&client->dev, "Unsupported chip ID: %x\n", ret);
> -		return -ENODEV;
> -	}
> +	dev_info(&client->dev, "VERSIONCRC is %02x\n", ret);
> 
>  	tps6586x = kzalloc(sizeof(struct tps6586x), GFP_KERNEL);
>  	if (tps6586x == NULL)
> --
> 1.7.0.4

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/