linux-kernel - Re: [PATCH 2/3] Input: synaptics - add multi-finger and semi-mt support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Dec 2010 17:59:56 +0100
From:	"Henrik Rydberg" <rydberg@...omail.se>
To:	Chase Douglas <chase.douglas@...onical.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Jiri Kosina <jkosina@...e.cz>, Takashi Iwai <tiwai@...e.de>,
	Chris Bagwell <chris@...bagwell.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] Input: synaptics - add multi-finger and semi-mt
 support

> > Reported-by: Tobyn Bertram
> > Not-yet-signed-off-by: Takashi Iwai <tiwai@...e.de>
> > Not-yet-signed-off-by: Chase Douglas <chase.douglas@...onical.com>
> > Not-yet-signed-off-by: Chris Bagwell <chris@...bagwell.com>
> > Signed-off-by: Henrik Rydberg <rydberg@...omail.se>
> 
> You can keep my SOB.

Great, thanks.
 
> > +static void set_slot(struct input_dev *dev, int slot, bool active, int x, int y)
> > +{
> > +	input_mt_slot(dev, slot);
> > +	input_mt_report_slot_state(dev, MT_TOOL_FINGER, active);
> > +	if (active) {
> > +		input_report_abs(dev, ABS_MT_POSITION_X, x);
> > +		input_report_abs(dev, ABS_MT_POSITION_Y,
> > +				 YMAX_NOMINAL + YMIN_NOMINAL - y);
> > +	}
> > +}
> 
> I take it that you feel MT_TOOL_FINGER should always be set, even if
> it's always the same as BTN_TOOL_*? I just want to be sure this is
> intended so we document it appropriately.

Yes - the MT_TOOLs are only emitted when explicitly set in absbit, but
the internal interface always handles it. This is actually documented
in the code (and DocBook).

> 
> > @@ -623,6 +686,7 @@ static void set_input_params(struct input_dev *dev, struct synaptics_data *priv)
> >  	int i;
> >  
> >  	__set_bit(INPUT_PROP_POINTER, dev->propbit);
> > +	__set_bit(INPUT_PROP_SEMI_MT, dev->propbit);
> 
> Shouldn't this only be set when SYN_CAP_ADV_GESTURE(priv->ext_cap_0c) is
> true?

Indeed - thanks.

Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/