linux-kernel - Re: [PATCH 2/2] ACPI: Fixed some coding style issues in fan.c and battery.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 21 Dec 2010 21:41:41 -0200
From:	Thiago Farina <tfransosi@...il.com>
To:	Jan Füsting <jan.fuesting@....de>
Cc:	lenb@...nel.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ACPI: Fixed some coding style issues in fan.c and battery.c

On Tue, Dec 21, 2010 at 7:41 PM, Jan Füsting <jan.fuesting@....de> wrote:
> Fixed some coding style issues in fan.c and battery.c
>
Which kind of coding style issues you have fixed? Looking at the diff
I couldn't figure out the *issues* as described in the commit message.
Care to resend describing which coding style issues you are fixing?

Also the diff shows a change only in batter.c. Did you forget
something (fan.c) ?

Thanks.

Ah, another thing, you have repeated the subject in the commit
message, if they almost the same except the ACPI, then no need to
repeat it in the commit message.

> Signed-off-by: Jan Füsting <jan.fuesting@....de>
> ---
>  drivers/acpi/battery.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> index 16fc4df..35d0c6f 100644
> --- a/drivers/acpi/battery.c
> +++ b/drivers/acpi/battery.c
> @@ -580,7 +580,7 @@ static void acpi_battery_quirks(struct acpi_battery *battery)
>  {
>        if (dmi_name_in_vendors("Acer") && battery->power_unit)
>                set_bit(ACPI_BATTERY_QUIRK_SIGNED16_CURRENT, &battery->flags);
> -}
> +}
>
>  /*
>  * According to the ACPI spec, some kinds of primary batteries can
> --
> 1.7.2.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/