linux-kernel - Re: [V2 PATCH] kthread_work: Make lockdep happy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Dec 2010 11:12:47 +0800
From:	Yong Zhang <yong.zhang0@...il.com>
To:	Andy Walls <awalls@...metrocast.net>
Cc:	Tejun Heo <tj@...nel.org>, linux-kernel@...r.kernel.org,
	nicolas.mailhot@...oste.net, Jarod Wilson <jarod@...hat.com>,
	Ingo Molnar <mingo@...hat.com>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Hans Verkuil <hverkuil@...all.nl>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [V2 PATCH] kthread_work: Make lockdep happy

On Wed, Dec 22, 2010 at 8:39 AM, Andy Walls <awalls@...metrocast.net> wrote:
> Yong,
>
> I have tested your patch with the following patch on top of yours.  I
> find the two patches together acceptable in testing in a machine with
> both a PVR-350 card and a PVR-500 card installed.
>
> Tested-by: Andy Walls <awalls@...metrocast.net>
> Signed-off-by: Andy Walls <awalls@...metrocast.net>
>
> Could you please author a [V3 PATCH] adding my changes?

Sure. Will do it.

> Since the
> majority of the change is your work, it should be attributed to you as
> the author.
>
>
> About my additional changes:
>
> I needed the explicit EXPORT_SYMBOL_GPL(__init_kthread_worker),
> otherwise the build would fail, because the ivtv module had an
> unresolved symbol.

Will update.

>
> I added the lockdep class name to make it easier to identify the ivtv
> module's kthread worker's lock class.  Now one can actually recognize
> the lock class in lockdep output strings:
>
>        # cat lockdep | grep itv
>        ffffffffa0483a60 FD:    1 BD:    1 ......: (&itv->irq_worker)->lock

Yeah, I like your idea.

V3 coming soon :)

Thanks,
Yong
-- 
Only stand for myself.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/