linux-kernel - Re: [PATCH 0/9] ASoC: codecs: Fix register cache incoherencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Dec 2010 16:38:41 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	Liam Girdwood <lrg@...mlogic.co.uk>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/9] ASoC: codecs: Fix register cache incoherencies

On 12/24/2010 03:57 PM, Mark Brown wrote:
> > On Fri, Dec 24, 2010 at 02:47:55PM +0100, Lars-Peter Clausen wrote:
>> >> The multi-component patch(commit f0fba2ad1) introduced a generic register cache
>> >> framework. Most of the drivers where converted to use this new framework. But
> >
> > No it didn't - soc-cache.c has been present since the middle of 2009.
Hm. Ok, you are right, I've should have checked more closely. Only the allocation of
the register cache was moved from the drivers to the core.

So the commit messages should have been along the lines of:
	The multi-component patch(commit f0fba2ad1) moved the alloction of the
	register cache from drivers to the ASoC core. While most of the drivers were
	converted to respect this change, some still maintain their own register
	cache besides the one used and allocated by the core.
	Thus the device ends up with two from each other incoherent caches, which
	can lead to undefined behaviour.

If there are no other issues with this series, I'll resend it with adjusted commit
messages in a few days.

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/