linux-kernel - Re: [PATCH][zram] Do not check for init flag before starting I/O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 30 Dec 2010 12:09:00 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Nitin Gupta <ngupta@...are.org>
Cc:	Greg KH <greg@...ah.com>, Pekka Enberg <penberg@...helsinki.fi>,
	Dennis Jansen <dennis.jansen@....de>,
	Linux Driver Project <devel@...uxdriverproject.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Anton Blanchard <anton@...ba.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH][zram] Do not check for init flag before starting I/O

On Thu, Dec 30, 2010 at 11:02 AM, Nitin Gupta <ngupta@...are.org> wrote:
>
> This commit shows oops in zram_inc_stat() which does not exist in staging
> tree version of zram. Its actually a problem with zram version as present in
> project's own repository where we allocate struct zram_stats_cpu upon device
> initialization. OTOH, In mainline/staging version of zram, we allocate
> struct stats upfront, so this oops cannot happen in mainline version.
>
> So, this commit is not even applicable for mainline/staging tree.  My bad, I
> didn't get a chance to review that patch.

Ok. So it really is a revert, and the commit message for the revert
should have explained that.

I changed the commit message appropriately, and committed it as the
attached commit.

                            Linus

View attachment "patch.diff" of type "text/x-patch" (6497 bytes)