lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 04 Jan 2011 08:34:00 +0800 From: Joe Jin <joe.jin@...cle.com> To: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> CC: jeremy@...p.org, xen-devel@...ts.xensource.com, ian.campbell@...rix.com, gurudas.pai@...cle.com, guru.anbalagane@...cle.com, greg.marsden@...cle.com, linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org> Subject: Re: [Xen-devel] Re: [patch] xenfb: fix xenfb suspend/resume race On 01/04/11 00:34, Konrad Rzeszutek Wilk wrote: >>> I am unclear from your description whether the patch fixes >>> the problem (I would presume so). Or does it take a long time >>> to hit this race? >>> >> Yes, more than 100 migrations. we hit this issue around 3 times. > > OK, so you are still trying to find the culprit. > > Did you look at this patch from Ian: > > https://patchwork.kernel.org/patch/403192/ We have reproduced the issue with the patch. > > ? >> >> I dumped vmcore when guest crashed, from vmcore everything >> looked good, fb_info, xenfb_info and so on. > > And the event channels are correct? > > .. snip.. >> diff --git a/drivers/xen/events.c b/drivers/xen/events.c >> index ac7b42f..4cfb5e2 100644 >> --- a/drivers/xen/events.c >> +++ b/drivers/xen/events.c >> @@ -175,6 +175,8 @@ static struct irq_info *info_for_irq(unsigned irq) >> >> static unsigned int evtchn_from_irq(unsigned irq) >> { >> + if (unlikely(irq < 0 || irq >= nr_irqs)) >> + return 0; > > You could insert a WARN_ON here to see see if you get this during your > migration process. > > Or use xen_raw_printk in case the guest is hung for good. > Thanks for your advice, will try it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists