linux-kernel - RE: [064/152] driver/net/benet: fix be_cmd_multicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 5 Jan 2011 21:29:23 -0800
From:	<Sathya.Perla@...lex.Com>
To:	<gregkh@...e.de>, <linux-kernel@...r.kernel.org>,
	<stable@...nel.org>
CC:	<stable-review@...nel.org>, <torvalds@...ux-foundation.org>,
	<akpm@...ux-foundation.org>, <alan@...rguk.ukuu.org.uk>,
	<subbu.seetharaman@...lex.com>, <Sarveshwar.Bandi@...lex.Com>,
	<Ajit.Khaparde@...lex.Com>, <joe.jin@...cle.com>,
	<davem@...emloft.net>
Subject: RE: [064/152] driver/net/benet: fix be_cmd_multicast_set() memcpy
 bug

The patch below is fine. Thanks.

-Sathya

-----Original Message-----
From: Greg KH [mailto:gregkh@...e.de] 
Sent: Thursday, January 06, 2011 5:53 AM
To: linux-kernel@...r.kernel.org; stable@...nel.org
Cc: stable-review@...nel.org; torvalds@...ux-foundation.org; akpm@...ux-foundation.org; alan@...rguk.ukuu.org.uk; Perla, Sathya; Seetharaman, Subramanian; Bandi, Sarveshwar; Khaparde, Ajit; Joe Jin; David S. Miller
Subject: [064/152] driver/net/benet: fix be_cmd_multicast_set() memcpy bug

2.6.36-stable review patch.  If anyone has any objections, please let us know.

------------------


From: Joe Jin <joe.jin@...cle.com>

[ Upstream commit 3fd40d0ceac9c234243730f4d7a6ffdb2fd3023a ]

Regarding  benet be_cmd_multicast_set() function, now using
netdev_for_each_mc_addr() helper for mac address copy, but
when copying to req->mac[] did not increase of the index.

Cc: Sathya Perla <sathyap@...verengines.com>
Cc: Subbu Seetharaman <subbus@...verengines.com>
Cc: Sarveshwar Bandi <sarveshwarb@...verengines.com>
Cc: Ajit Khaparde <ajitk@...verengines.com>
Signed-off-by: Joe Jin <joe.jin@...cle.com>
Signed-off-by: David S. Miller <davem@...emloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
---
 drivers/net/benet/be_cmds.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/benet/be_cmds.c
+++ b/drivers/net/benet/be_cmds.c
@@ -1179,7 +1179,7 @@ int be_cmd_multicast_set(struct be_adapt
 
 		i = 0;
 		netdev_for_each_mc_addr(ha, netdev)
-			memcpy(req->mac[i].byte, ha->addr, ETH_ALEN);
+			memcpy(req->mac[i++].byte, ha->addr, ETH_ALEN);
 	} else {
 		req->promiscuous = 1;
 	}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/