linux-kernel - Re: [PATCH] trace event skb remove duplicate null-pointer check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 06 Jan 2011 10:37:34 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	fweisbec@...il.com
Cc:	mathieu.desnoyers@...icios.com, rostedt@...dmis.org,
	nhorman@...driver.com, zhaolei@...fujitsu.com,
	linux-kernel@...r.kernel.org, mingo@...e.hu, tglx@...utronix.de
Subject: Re: [PATCH] trace event skb remove duplicate null-pointer check

From: Frederic Weisbecker <fweisbec@...il.com>
Date: Thu, 6 Jan 2011 19:17:29 +0100

> On Thu, Jan 06, 2011 at 10:15:44AM -0800, David Miller wrote:
>> From: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
>> Date: Thu, 6 Jan 2011 12:53:19 -0500
>> 
>> > The check for NULL skb in the kfree_skb trace event is a duplicate from the
>> > check already done in its only caller, kfree_skb(). Remove this duplicate check.
>> > 
>> > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
>> > Acked-by: Neil Horman <nhorman@...driver.com>
>> 
>> Acked-by: David S. Miller <davem@...emloft.net>
> 
> May be you want to take that on the net tree? Looks like more appropriate.
> Of course this can go through the tracing tree as well.

You guys can take it in the tracing tree, this actually makes things
easier for me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/