linux-kernel - Re: [PATCH 1/2] kbuild: asm-generic support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 9 Jan 2011 16:10:41 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	linux-kbuild <linux-kbuild@...r.kernel.org>,
	linux arch <linux-arch@...r.kernel.org>,
	Guan Xuetao <guanxuetao@...c.pku.edu.cn>,
	Michal Marek <mmarek@...e.cz>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH 1/2] kbuild: asm-generic support

On Sun, Jan 09, 2011 at 03:03:33PM +0100, Arnd Bergmann wrote:
> Hi Sam,
> 
> Looks much cleaner to me now, but I still don't see why we even need
> the new generic-export-y variable in addition to export-y. Can't we
> just simply install all $(filter-out, $(generated-y), $(header-y))
> from arch/$(SRCARCH)/include/asm and all $(filter, $(generated-y),
> $(header-y)) from rch/$(SRCARCH)/include/generated/asm?

Like this:

diff --git a/scripts/Makefile.headersinst b/scripts/Makefile.headersinst
index 3a630c2..7c06dcf 100644
--- a/scripts/Makefile.headersinst
+++ b/scripts/Makefile.headersinst
@@ -31,10 +31,10 @@ check-file    := $(install)/.check
 # generic-export-y list all generic headers to be exported
 # generic-y list all files an architecture uses from asm-generic
 # Use this to build a list of headers which require a wrapper
-wrapper-files := $(filter $(generic-export-y), $(generic-y))
+wrapper-files := $(filter $(header-y), $(generic-y))
 
 # all headers files for this dir
-header-y      := $(filter-out $(wrapper-files), $(header-y))
+header-y      := $(filter-out $(generic-y), $(header-y))
 all-files     := $(header-y) $(objhdr-y) $(generic-y)
 input-files   := $(addprefix $(_src)/,$(header-y)) \
                  $(addprefix $(objtree)/$(obj)/,$(objhdr-y))


And then reverting the changes to Kbuild.asm.
Yes this works - and is much simpler. Good!

I originally wanted to know wat set of files I worked
with but this is not needed.

I will test it a bit more tonight and post a v3 of the patchset.

Thanks for the review!

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/