linux-kernel - Re: [PATCH v2 1/7] Introduce delete_from_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 11 Jan 2011 00:39:00 +0900
From:	Minchan Kim <minchan.kim@...il.com>
To:	Johannes Weiner <hannes@...xchg.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-mm <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Hugh Dickins <hughd@...gle.com>,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH v2 1/7] Introduce delete_from_page_cache

On Sun, Jan 9, 2011 at 7:16 AM, Johannes Weiner <hannes@...xchg.org> wrote:
> On Mon, Jan 03, 2011 at 12:44:30AM +0900, Minchan Kim wrote:
>> This function works as just wrapper remove_from_page_cache.
>> The difference is that it decreases page references in itself.
>> So caller have to make sure it has a page reference before calling.
>>
>> This patch is ready for removing remove_from_page_cache.
>>
>> Cc: Christoph Hellwig <hch@...radead.org>
>> Acked-by: Hugh Dickins <hughd@...gle.com>
>> Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
>> Signed-off-by: Minchan Kim <minchan.kim@...il.com>
>> ---
>>  include/linux/pagemap.h |    1 +
>>  mm/filemap.c            |   17 +++++++++++++++++
>>  2 files changed, 18 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
>> index 9c66e99..7a1cb49 100644
>> --- a/include/linux/pagemap.h
>> +++ b/include/linux/pagemap.h
>> @@ -457,6 +457,7 @@ int add_to_page_cache_lru(struct page *page, struct address_space *mapping,
>>                               pgoff_t index, gfp_t gfp_mask);
>>  extern void remove_from_page_cache(struct page *page);
>>  extern void __remove_from_page_cache(struct page *page);
>> +extern void delete_from_page_cache(struct page *page);
>>
>>  /*
>>   * Like add_to_page_cache_locked, but used to add newly allocated pages:
>> diff --git a/mm/filemap.c b/mm/filemap.c
>> index 095c393..1ca7475 100644
>> --- a/mm/filemap.c
>> +++ b/mm/filemap.c
>> @@ -166,6 +166,23 @@ void remove_from_page_cache(struct page *page)
>>  }
>>  EXPORT_SYMBOL(remove_from_page_cache);
>>
>> +/**
>> + * delete_from_page_cache - delete page from page cache
>> + *
>
> This empty line is invalid kerneldoc, the argument descriptions must
> follow the short function description line immediately.

Thanks, Hannes.
Will fix.

>
> Otherwise,
> Reviewed-by: Johannes Weiner <hannes@...xchg.org>
>


-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/