linux-kernel - Re: [PATCH] Rename struct task variables from p to tsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 Jan 2011 14:23:25 -0600 (CST)
From:	Christoph Lameter <cl@...ux.com>
To:	Eric B Munson <emunson@...bm.net>
cc:	akpm@...ux-foundation.org, linux-mm@...ck.org, mel@....ul.ie,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Rename struct task variables from p to tsk

On Wed, 12 Jan 2011, Eric B Munson wrote:

> On Wed, 12 Jan 2011, Christoph Lameter wrote:
> > Use t instead of p? Its a local variable after all.
>
> I don't find t any more informative than p.  As a newcomer to most of this code
> informative variable names, even for local variables, is a huge help.

Local variables are short because they are defined close to the point of
use.

tsk is not that informative and the notion of a "task" can refer to
various. However, when I see

	struct task_struct *t;

I know what it refers to.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/