| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 13 Jan 2011 15:44:28 -0800 From: Greg KH <greg@...ah.com> To: Sutharsan Ramamoorthy <sutharsan.ramamoorthy@...oo.com> Cc: tony@...mide.com, linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org, linux-usb@...r.kernel.org, david.cross@...ress.com, srmt@...ress.com Subject: Re: [PATCH] adding gpmc configuration functions, west bridge related On Thu, Jan 13, 2011 at 03:23:14PM -0800, Sutharsan Ramamoorthy wrote: > This patch implements gpmc configuration functions needed by westbridge > device controller driver in staging tree. These functions currently > implemented in staging tree. This patch is part of the effort to bring > westbridge device controller driver out of staging tree. > > Signed-off by: Sutharsan Ramamoorthy <sutharsan.ramamoorthy@...oo.com> Close, but not quite. Why remove your cypress.com email address here? That's who really is "signing off" on this patch, right? Also, please note my previous comments about "lots more needs to be done to the driver before this can even start to move out of the staging tree". Moving these functions should be one of the _last_ things that happens, not the first. Please work on cleaning up the code in the drivers/staging/westbridge/ directory first. When that is all done, _then_ we can start moving it out. Ok? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists