linux-kernel - Re: vfs-scale, d_revalidate from nfsd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 14 Jan 2011 03:38:46 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Nick Piggin <npiggin@...il.com>
Cc:	"J. R. Okajima" <hooanon05@...oo.co.jp>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: vfs-scale, d_revalidate from nfsd

On Fri, Jan 14, 2011 at 02:29:11PM +1100, Nick Piggin wrote:
> > ? ? ? ?if (nd->flags & LOOKUP_RCU)
> > ? ? ? ? ? ? ? ?return -ECHILD;
> > ? ? ? ?return -EPERM;
> > }
> > when the sole intent of that sucker is to have dentry of /.xattr (pinned
> > in dcache and hashed all along) rejected on lookups from root? ?IOW, WTF
> > bother with -ECHILD here at all?
> 
> That's true. I guess I always have a weakness for doing "just one
> little easy optimisation/simplification" folded into patch that is supposed
> to be more mechanical changes :) I did have exactly that in the patch
> initially, but I decided it's better just to do everything with -ECHILD first.
> 
> That also gives the -ECHILD paths a bit more workout before
> fs conversions are done, too.

Not unless your test loads include trying to access pathnames like
/.xattr/whatever on reiserfs and watching those attempts fail...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/