linux-kernel - Re: [PATCH] staging: fix build failure in bcm driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 14 Jan 2011 17:50:04 -0800
From:	Andres Salomon <dilinger@...ued.net>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	devel@...verdev.osuosl.org, Arnd Bergmann <arnd@...db.de>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] staging: fix build failure in bcm driver

On Fri, 14 Jan 2011 17:37:13 -0800
Stephen Hemminger <shemminger@...tta.com> wrote:

> On Fri, 14 Jan 2011 17:24:39 -0800
> Andres Salomon <dilinger@...ued.net> wrote:
> 
> > While building, I hit the following:
> > 
> >   CC [M]  drivers/staging/bcm/Qos.o
> > drivers/staging/bcm/Qos.c: In function ‘PruneQueue’:
> > drivers/staging/bcm/Qos.c:367: error: ‘struct netdev_queue’ has no
> > member named ‘tx_dropped’ drivers/staging/bcm/Qos.c: In function
> > ‘flush_all_queues’: drivers/staging/bcm/Qos.c:416: error: ‘struct
> > netdev_queue’ has no member named ‘tx_dropped’ make[5]: ***
> > [drivers/staging/bcm/Qos.o] Error 1 make[4]: ***
> > [drivers/staging/bcm] Error 2 make[3]: *** [drivers/staging] Error 2
> > 
> > As well as:
> > 
> >   CC [M]  drivers/staging/bcm/Transmit.o
> > drivers/staging/bcm/Transmit.c: In function ‘SetupNextSend’:
> > drivers/staging/bcm/Transmit.c:163: error: ‘struct netdev_queue’
> > has no member named ‘tx_bytes’ drivers/staging/bcm/Transmit.c:164:
> > error: ‘struct netdev_queue’ has no member named ‘tx_packets’
> > make[2]: *** [drivers/staging/bcm/Transmit.o] Error 1
> > 
> > 
> > tx_dropped/tx_bytes_tx_packets were removed in commit 1ac9ad13.
> > This patch converts bcm to use net_device_stats instead of
> > netdev_queue.
> > 
> > Signed-off-by: Andres Salomon <dilinger@...ued.net>
> > 
> 
> Don't think this is necessary.
> What kernel version? and kernel config?
> I suspect the problem is a missing dependency on multiqueue support.


Current linus git (38567333).  Kernel config is attached.


Download attachment ".config" of type "application/octet-stream" (126845 bytes)