linux-kernel - Re: [PATCH resend] fs/eventpoll.c: fix compilation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 15 Jan 2011 11:10:19 +0000
From:	Jack Stone <jwjstone@...tmail.fm>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Shawn Bohrer <shawn.bohrer@...il.com>
CC:	Viresh Kumar <viresh.kumar@...com>, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, viro@...iv.linux.org.uk
Subject: Re: [PATCH resend] fs/eventpoll.c: fix compilation warning

"Andrew Morton" <akpm@...ux-foundation.org> wrote:
>I've looked at this warning several times - the code is non-buggy and
>it's a bit sad to add extra instructions unnecessarily.  It would be
>better to make this warning go away by cleaning up or restructuring the
>code.  
>
>And the code _is_ pretty stupid.  If timed_out is set to 1 then the
>function does a great pile of useless junk.  I had a quick tinkle, made
>things worse and gave up:

[snip]

>I think the attempt to munge the "timeout==0" spacial case into the
>main body of the polling loop was a mistake, and that the code would be
>better/cleaner if that special case was handled quite separately.

I can have a go at a patch later on today if you wish.

Thanks,

Jack


-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/