linux-kernel - Re: [git pull] vfs pile 2 (automount work)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 16 Jan 2011 21:44:26 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Joachim Eastwood <manabian@...il.com>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [git pull] vfs pile 2 (automount work)

On Sun, Jan 16, 2011 at 01:37:54PM -0800, Linus Torvalds wrote:
> On Sun, Jan 16, 2011 at 1:15 PM, Joachim  Eastwood <manabian@...il.com> wrote:
> >
> > f03c65993b98eeb909a4012ce7833c5857d74755 - sanitize vfsmount refcounting changes
> >
> > Breaks my ARM !CONFIG_SMP compile
> 
> In fact, any non-SMP compile, it's not ARM-specific.
> 
> The simple fix for the build breakage should be to just move the
> mnt_longterm thing out of the #ifdef CONFIG_SMP in
> include/linux/mount.h. But I do worry that it would cause some count
> imbalance, because there are some accesses that are still inside that
> CONFIG_SMP case in mntput_no_expire().
> 
> Al, please take a look,

Already fixed.  Actually, taking it out of ifdef would work (the only
place that actually cares about the value of that sucker is SMP side
of mntput()), but we are obviously better off just not touching it on
UP at all - why do pointless work and waste space?

See the patch upthread.  ->mnt_longterm is SMP-only optimization of
mntput(); it's there only to free the common case of mntput() from
cacheline bouncing and on UP it's needed at all.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/