linux-kernel - Re: [PATCH v2] spi: New driver for Altera SPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 Jan 2011 14:22:06 +0800
From:	Thomas Chou <thomas@...ron.com.tw>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
CC:	David Brownell <dbrownell@...rs.sourceforge.net>,
	Grant Likely <grant.likely@...retlab.ca>,
	nios2-dev@...c.et.ntust.edu.tw, Mike Frysinger <vapier@...too.org>,
	devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	spi-devel-general@...ts.sourceforge.net
Subject: Re: [PATCH v2] spi: New driver for Altera SPI

On 01/17/2011 01:59 PM, Stephen Rothwell wrote:
>> +/*
>> + * struct altera_spi_platform_data - platform data of the Altera SPI
>> + * @interrupt:	use intrrupt driven data transfer.
>> + */
>> +struct altera_spi_platform_data {
>> +	int interrupt;
>> +};
>
> Is there some reason that this struct definition cannot just be placed
> in spi_altera.c and so save a whole extra file (and its inclusion)?
>

Hi Stephen,

It is needed for board configuration file to attach this platform data, 
which is used to choose between interrupt driven data transfer or 
polling method. The data transfer rate is usually faster for polling, as 
interrupt overhead is higher.

Best regards,
Thomas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/