linux-kernel - Re: [PATCH 13 of 66] export maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 18 Jan 2011 15:29:42 +0100
From:	Michal Simek <monstr@...str.eu>
To:	Andrea Arcangeli <aarcange@...hat.com>
CC:	linux-mm@...ck.org, Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Adam Litke <agl@...ibm.com>, Avi Kivity <avi@...hat.com>,
	Hugh Dickins <hugh.dickins@...cali.co.uk>,
	Rik van Riel <riel@...hat.com>, Mel Gorman <mel@....ul.ie>,
	Dave Hansen <dave@...ux.vnet.ibm.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Ingo Molnar <mingo@...e.hu>, Mike Travis <travis@....com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Chris Wright <chrisw@...s-sol.org>, bpicco@...hat.com,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Johannes Weiner <hannes@...xchg.org>,
	Daisuke Nishimura <nishimura@....nes.nec.co.jp>,
	Chris Mason <chris.mason@...cle.com>,
	Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH 13 of 66] export maybe_mkwrite

Andrea Arcangeli wrote:
> Hi Michal,
> 
> On Mon, Jan 17, 2011 at 03:14:07PM +0100, Michal Simek wrote:
>> Andrea Arcangeli wrote:
>>> From: Andrea Arcangeli <aarcange@...hat.com>
>>>
>>> huge_memory.c needs it too when it fallbacks in copying hugepages into regular
>>> fragmented pages if hugepage allocation fails during COW.
>>>
>>> Signed-off-by: Andrea Arcangeli <aarcange@...hat.com>
>>> Acked-by: Rik van Riel <riel@...hat.com>
>>> Acked-by: Mel Gorman <mel@....ul.ie>
>> It wasn't good idea to do it. mm/memory.c is used only for system with 
>> MMU. System without MMU are broken.
>>
>> Not sure what the right fix is but anyway I think use one ifdef make 
>> sense (git patch in attachment).
> 
> Can you show the build failure with CONFIG_MMU=n so I can understand
> better? Other places in mm.h depends on pte_t/vm_area_struct/VM_WRITE
> to be defined, if a system is without MMU nobody should call it
> simply. Not saying your patch is wrong, but I'm trying to understand
> how exactly it got broken and the gcc error would show it immediately.
> 
> This is only called by memory.o and huge_memory.o and they both are
> built only if MMU=y.

Of course: Look for example at this page:
http://www.monstr.eu/wiki/doku.php?id=log:2011-01-18_11_51_49#linux_next

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/