linux-kernel - Re: [PATCH] pxa3xx: fix PXA GPIO IRQ handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 18 Jan 2011 17:20:34 +0100
From:	Lennert Buijtenhek <buytenh@...tstofly.org>
To:	Eric Miao <eric.y.miao@...il.com>
Cc:	Lars-Peter Clausen <lars@...afoo.de>,
	Sven Neumann <s.neumann@...mfeld.com>,
	linux-arm-kernel@...ts.infradead.org,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org, Daniel Mack <daniel@...aq.de>
Subject: Re: [PATCH] pxa3xx: fix PXA GPIO IRQ handling

On Tue, Jan 18, 2011 at 08:15:22AM -0800, Eric Miao wrote:

> >> Set the "set_wake" field of the irq_chip struct before calling
> >> set_irq_chip() for all of the IRQs, so that the compat handler
> >> actually gets installed.
> 
> Not really sure if this is necessary. Lennert has done the transition to
> irq_data to those _set_wake() functions as well, so it should be OK
> that compat handler doesn't get installed.

Yeah, this has been dealt with upstream, and this patch won't apply.


> >> diff --git a/arch/arm/mach-pxa/irq.c b/arch/arm/mach-pxa/irq.c
> >> index 1beb40f..a5b42a7 100644
> >> --- a/arch/arm/mach-pxa/irq.c
> >> +++ b/arch/arm/mach-pxa/irq.c
> >> @@ -111,13 +111,13 @@ static void __init pxa_init_low_gpio_irq(set_wake_t fn)
> >>       GRER0 &= ~0x3;
> >>       GEDR0 = 0x3;
> >>
> >> +     pxa_low_gpio_chip.set_wake = fn;
> >> +
> >>       for (irq = IRQ_GPIO0; irq <= IRQ_GPIO1; irq++) {
> >>               set_irq_chip(irq, &pxa_low_gpio_chip);
> >>               set_irq_handler(irq, handle_edge_irq);
> >>               set_irq_flags(irq, IRQF_VALID);
> >>       }
> >> -
> >> -     pxa_low_gpio_chip.set_wake = fn;

Upstream has:

        pxa_low_gpio_chip.irq_set_wake = fn;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/