linux-kernel - Re: [PATCH] drm/i915: Correctly test for an initialised ring for dri1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Jan 2011 14:24:49 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Chris Wilson <chris@...is-wilson.co.uk>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/i915: Correctly test for an initialised ring for
	dri1

On Tue, Jan 18, 2011 at 05:24:09PM +0000, Chris Wilson wrote:
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 46d649b..19a58bd 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -1302,12 +1302,12 @@ int i915_irq_emit(struct drm_device *dev, void *data,
>  	drm_i915_irq_emit_t *emit = data;
>  	int result;
>  
> -	if (!dev_priv || !LP_RING(dev_priv)->virtual_start) {
> +	if (!dev_priv || !LP_RING(dev_priv)->obj) {
>  		DRM_ERROR("called with no initialization\n");
>  		return -EINVAL;
>  	}
>  
> -	RING_LOCK_TEST_WITH_RETURN(dev, file_priv);
> +	LOCK_TEST_WITH_RETURN(dev, file_priv);

While this would surely fix the crash here, this appears to take
away existing functionality with KMS off.

We usually don't require people to upgrade user-space along
with the kernel in order to preserve existing functionality.
Do different rules apply in the DRM area?

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/