linux-kernel - Re: [PATCH] Westbridge software module, fixes errors reported by checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 18 Jan 2011 20:31:27 -0800
From:	Greg KH <greg@...ah.com>
To:	Sutharsan Ramamoorthy <sutharsan.ramamoorthy@...oo.com>
Cc:	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	david.cross@...ress.com, srmt@...ress.com
Subject: Re: [PATCH] Westbridge software module, fixes errors reported by
 checkpatch.pl

On Mon, Jan 17, 2011 at 03:59:09PM -0800, Sutharsan Ramamoorthy wrote:
> From: Sutharsan Ramamoorthy <srmt@...ress.com>
> 
> This patch fixes errors in westbridge device controller driver in the 
> staging tree reported by checkpatch.pl. File containing EXPORT_SYMBOL() 
> macros for all the API's exported by the westbridge software has been 
> removed. EXPORT_SYMBOL() macro's are added after the functions being 
> exported. This patch also fixes some function prototype definitions and 
> removes new typdefs.

Care to split this into two patches?  Every patch should only do one
thing at a time.

> +struct cyasdevice {
>          /* Handle to the Antioch device */
>          cy_as_device_handle            dev_handle;
>          /* Handle to the HAL */
>          cy_as_hal_device_tag            hal_tag;
>          spinlock_t      common_lock;
>          unsigned long flags;
> -} cyasdevice;
> +} ;

What's with the extra space here?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/