linux-kernel - Re: [PATCH] Use sed instead of perl to generate x86/kernel/cpu/capflags.c.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 19 Jan 2011 12:57:24 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Rob Landley <rlandley@...allels.com>
Cc:	Jesper Juhl <jj@...osbits.net>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>, Yinghai Lu <yinghai@...nel.org>,
	Tejun Heo <tj@...nel.org>, Don Zickus <dzickus@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Use sed instead of perl to generate
 x86/kernel/cpu/capflags.c.

On Tue, Jan 18, 2011 at 02:58:27PM -0600, Rob Landley wrote:
>
>From: Rob Landley <rlandley@...allels.com>
>
>Replace perl header file generator with smaller/faster/simpler C version.
>
>Signed-off-by: Rob Landley <rlandley@...allels.com>

Pretty nice!

One small problem below.

>
>I ran the attached test script to compare the output of the C program
>with the output of the perl version for every HZ from 1 to 5000 to make
>sure it was producing the same constants.
>


I think you can use diff to compare the perl output and C output,
with different HZ values.


>+	fprintf(file, "#endif /* __KERNEL_TIMECONST_H */\n");
>+
>+	/* Notice if the disk fills up. */
>+
>+	fflush(stdout);
>+	return ferror(stdout);


Why do you fflush stdout while you are writing to 'file'?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/