linux-kernel - Re: [v4 3/3] 3/3 spi: Cypress TTSP G3 SPI Device Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Jan 2011 01:27:39 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Trilok Soni <tsoni@...eaurora.org>
Cc:	Kevin McNeely <Kevin.McNeely@...ress.com>,
	David Brown <davidb@...eaurora.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Eric Miao <eric.y.miao@...il.com>,
	Mike Frysinger <vapier@...too.org>,
	Henrik Rydberg <rydberg@...omail.se>,
	Alan Cox <alan@...ux.intel.com>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [v4 3/3] 3/3 spi: Cypress TTSP G3 SPI Device Driver

On Thu, Jan 20, 2011 at 04:40:35PM +0530, Trilok Soni wrote:
> Hi Dmitry,
> 
> On 1/13/2011 12:32 AM, Kevin McNeely wrote:
> > Hi Dmitry,
> > 
> > Thank you for your review.
> > 
> > Will the existing patches get into the current merge?
> > 
> > Can I revisit this discussion as part of our plan to provide a Protocol
> > B driver?
> > 
> > Thanks and best regards,
> > Kevin
> > 
> 
> Any updates on Kevin's question here?
> 

Hi Trilok, Kevin,

Ah, sorry, was not feeling well last week and lost track of this driver.

No, I am sorry, bit the driver is not quite ready to be merged. Aside of
SPI abort/timeout issues we also have cyttsp_close() implementation
busted (once you close device you lose irq) and bunch of other things I
need to look over. I also have concern about having protocol A now and
upgrading to protocol B: clients that only understand protocol A will
get broken at A->B transition. I think we should consider implementing B
right away for mainline (no, I do not want A/B config options).

Sorry for being slow with doing full review...

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/