lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 21 Jan 2011 15:40:55 -0200
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
Cc:	"Dr. David Alan Gilbert" <david.gilbert@...aro.org>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	mingo@...e.hu, dave.martin@...aro.org
Subject: Re: [PATCH] fix perf Annotation of Thumb code

Em Fri, Jan 21, 2011 at 08:17:18PM +0300, Sergei Shtylyov escreveu:
> >(For reference this corresponds to this bug
> >https://bugs.launchpad.net/linux-linaro/+bug/677547 )
> 
> >        Signed-off-by: Dr. David Alan Gilbert <david.gilbert@...aro.org>
> 
>    Hm, I think there should be no spaces/tabs before signoff...
> 
> >+			sym.st_value-=1;
> 
>   The coding style used suggests spaces around -=.
> 
> WBR, Sergei

I noticed both issues and will fix them up when applying the patch.

Thanks

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ