linux-kernel - [PATCH] fsnotify.h: Dropped redundant code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 24 Jan 2011 19:45:26 +0200
From:	Radu Voicilas <rvoicilas@...il.com>
To:	eparis@...hat.com
Cc:	linux-kernel@...r.kernel.org, Radu Voicilas <rvoicilas@...il.com>
Subject: [PATCH] fsnotify.h: Dropped redundant code.

The code that checks to see whether the provided dentry object is valid
or not is redundant with the one that's in fs/notify/fsnotify.c in
the __fsnotify_parent function:

    if (!dentry)
        dentry = path->dentry;

Signed-off-by: Radu Voicilas <rvoicilas@...il.com>
---
 include/linux/fsnotify.h |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/include/linux/fsnotify.h b/include/linux/fsnotify.h
index 2a53f10..9e67a41 100644
--- a/include/linux/fsnotify.h
+++ b/include/linux/fsnotify.h
@@ -27,9 +27,6 @@ static inline void fsnotify_d_instantiate(struct dentry *dentry,
 /* Notify this dentry's parent about a child's events. */
 static inline int fsnotify_parent(struct path *path, struct dentry *dentry, __u32 mask)
 {
-	if (!dentry)
-		dentry = path->dentry;
-
 	return __fsnotify_parent(path, dentry, mask);
 }
 
-- 
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/