linux-kernel - thinkpad-acpi: fn-f4 issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Jan 2011 13:13:46 -0200
From:	Henrique de Moraes Holschuh <hmh@....eng.br>
To:	Jeff Chua <jeff.chua.linux@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	platform-driver-x86@...r.kernel.org,
	ibm-acpi-devel@...ts.sourceforge.net
Subject: thinkpad-acpi: fn-f4 issues

(cc: trimmed down, as this is now a thinkpad-acpi matter)

On Tue, 25 Jan 2011, Jeff Chua wrote:
> As for the thinkpad-acpi, here a little patch to disable all hotkeys
> so that Fn-F4 works natively to suspend-to-memory when
> CONFIG_THINKPAD_ACPI_HOTKEY_POLL is not set.
> 
> Thanks,
> Jeff
> 
> --- lx/drivers/platform/x86/thinkpad_acpi.c.org	2011-01-22 21:48:05.000000000 +0800
> +++ lx/drivers/platform/x86/thinkpad_acpi.c	2011-01-22 21:55:14.000000000 +0800
> @@ -8776,10 +8776,12 @@
>  	{
>  		.data = &thinkpad_acpi_driver_data,
>  	},
> +#ifdef CONFIG_THINKPAD_ACPI_HOTKEY_POLL
>  	{
>  		.init = hotkey_init,
>  		.data = &hotkey_driver_data,
>  	},
> +#endif

That will basicaly lobotomize the driver, as the "hotkeys" are really the
entire firmware event interface(!).

Which thinkpad do you have that need CONFIG_THINKPAD_ACPI_HOTKEY_POLL to
handle Fn+F4?   I don't expect that to be needed on anything newer than a
T32...

Can I have the full kernel log, please?

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/