linux-kernel - Re: [PATCH 1/3] Avoid unmapping THP when it is failed to be split.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Jan 2011 23:01:18 +0100
From:	Andrea Arcangeli <aarcange@...hat.com>
To:	Jin Dongming <jin.dongming@...css.fujitsu.com>
Cc:	Andi Kleen <andi@...stfloor.org>,
	AKPM　 <akpm@...ux-foundation.org>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	Huang Ying <ying.huang@...el.com>,
	LKLM <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] Avoid unmapping THP when it is failed to be split.

On Tue, Jan 25, 2011 at 02:45:27PM +0900, Jin Dongming wrote:
> If the THP is failed to be split,
>    1. The processes using the poisoned page could not be collected.
>       (Because page_mapped_in_vma() in collect_procs_anon() always
>        returns NULL.)

page_mapped_in_vma is only called after split_huge_page without
requiring this change.

>    2. The poisoned page could not be unmapped.
>       (If CONFIG_DEBUG_VM is "y", VM_BUG_ON(PageTransHuge(page))
>        in try_to_unmap() will be called, and system panic will be
>        caused.)

This is more reasonable argument for the change because at times
collect_procs may fail kmalloc or for other reasons kill may be set to
1 without split_huge_page having run.

>    3. The processes using the poisoned page could not be killed, too.
>       (Because no process is collected in 1.)

I don't see the point of the change for 1.

> So if splitting THP is failed, it is better to stop unmapping
> rather than causing panic. System might servive if the page is freed
> later.

Splitting THP can't fail unless the page is freed under
split_huge_page (like if the process quits while you're calling
split_huge_page and in turn the anon_vma was already unusable).

Patch looks good but just for point 2.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/