lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 26 Jan 2011 21:04:01 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Haiyang Zhang <haiyangz@...rosoft.com>
Cc:	hjanssen@...rosoft.com, gregkh@...e.de,
	linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
	virtualization@...ts.osdl.org
Subject: Re: [PATCH 7/8] staging: hv: Convert camel cased struct fields in
 vmbus_packet_format.h to lower cases

On Wed, Jan 26, 2011 at 09:50:05AM -0800, Haiyang Zhang wrote:
> +	VM_PKT_INVALID				= 0x0,
> +	VM_PKT_SYNCH				= 0x1,
> +	VM_PKT_ADD_XFER_PAGESET		= 0x2,
> +	VM_PKT_RM_XFER_PAGESET		= 0x3,
                                          ^^^^
> +	VM_PKT_ESTABLISH_GPADL			= 0x4,
> +	VM_PKT_TEARDOWN_GPADL			= 0x5,
> +	VM_PKT_DATA_INBAND			= 0x6,
> +	VM_PKT_DATA_USING_XFER_PAGES		= 0x7,
> +	VM_PKT_DATA_USING_GPADL			= 0x8,
> +	VM_PKT_DATA_USING_GPA_DIRECT		= 0x9,
> +	VM_PKT_CANCEL_REQUEST			= 0xa,
> +	VM_PKT_COMP			= 0xb,
                                        ^^^^^^
> +	VM_PKT_DATA_USING_ADDITIONAL_PKT	= 0xc,
> +	VM_PKT_ADDITIONAL_DATA			= 0xd


These don't line up with the others.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ