linux-kernel - Re: [PATCH 4/4] msm: clock: Add support for more proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Jan 2011 14:04:39 -0800
From:	Daniel Walker <dwalker@...eaurora.org>
To:	David Brown <davidb@...eaurora.org>
Cc:	Stephen Boyd <sboyd@...eaurora.org>,
	Saravana Kannan <skannan@...eaurora.org>,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 4/4] msm: clock: Add support for more proc_comm clocks

On Wed, 2011-01-26 at 14:03 -0800, David Brown wrote:
> On Tue, Jan 25 2011, Daniel Walker wrote:
> 
> > On Mon, 2011-01-24 at 19:45 -0800, Stephen Boyd wrote:
> >> Support the CE_CLK and CODEC_SSBI_CLK. Also add support for uart,
> >> and i2c clocks on targets which support proc_comm clocks.
> >
> > Basically when you catch yourself writing "also" in the commit text you
> > need to re-evaluate making two patches.. In this case it looks
> > appropriate..
> 
> Or it is just an argument to not use the word also in the commit text.
> I don't think it's really necessary to split up a patch that adds a few
> clocks to the clock table.

This one it actually makes a lot of sense to break it up. He's doing
some very different things here all in the same patch ..

Daniel


-- 

Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/