linux-kernel - Re: linux-next: build warning after merge of the cifs tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 31 Jan 2011 07:29:27 -0500
From:	Jeff Layton <jlayton@...hat.com>
To:	Suresh Jayaraman <sjayaraman@...e.de>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Steve French <smfrench@...il.com>, linux-cifs@...r.kernel.org,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Pavel Shilovsky <piastryyy@...il.com>
Subject: Re: linux-next: build warning after merge of the cifs tree

On Mon, 31 Jan 2011 16:19:51 +0530
Suresh Jayaraman <sjayaraman@...e.de> wrote:

> On 01/31/2011 08:00 AM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the cifs tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> > 
> > fs/cifs/file.c: In function 'cifs_iovec_write':
> > fs/cifs/file.c:1740: warning: passing argument 6 of 'CIFSSMBWrite2' from incompatible pointer type
> > fs/cifs/cifsproto.h:343: note: expected 'unsigned int *' but argument is of type 'size_t *'
> > 
> > Introduced by commit 72432ffcf555decbbae47f1be338e1d2f210aa69 ("CIFS:
> > Implement cifs_strict_writev (try #4)").
> > 
> 
> The following patch should silence that warning.
> 
> From: Suresh Jayaraman <sjayaraman@...e.de>
> Subject: [PATCH] cifs: fix compiler warning about incompatible pointer type
> 
> fs/cifs/file.c: In function ‘cifs_iovec_write’:
> fs/cifs/file.c:1740:9: warning: passing argument 6 of ‘CIFSSMBWrite2’ from incompatible pointer type
> fs/cifs/cifsproto.h:343:12: note: expected ‘unsigned int *’ but argument is of type ‘size_t *’
> 
> Cc: Pavel Shilovsky <piastryyy@...il.com>
> Signed-off-by: Suresh Jayaraman <sjayaraman@...e.de>
> ---
>  fs/cifs/file.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/cifs/file.c b/fs/cifs/file.c
> index 0de17c1..2a3c5d8 100644
> --- a/fs/cifs/file.c
> +++ b/fs/cifs/file.c
> @@ -1667,7 +1667,7 @@ static ssize_t
>  cifs_iovec_write(struct file *file, const struct iovec *iov,
>  		 unsigned long nr_segs, loff_t *poffset)
>  {
> -	size_t total_written = 0, written = 0;
> +	unsigned int total_written = 0, written = 0;
>  	unsigned long num_pages, npages;
>  	size_t copied, len, cur_len, i;
>  	struct kvec *to_send;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

I fixed this a few days ago along with a number of other compiler
warnings in:

    [PATCH] cifs: clean up some compiler warnings

...just waiting for Steve to merge it.

-- 
Jeff Layton <jlayton@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/