linux-kernel - Re: [RFC Patch] virtio: export model and type in /sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 31 Jan 2011 08:02:19 -0600
From:	Anthony Liguori <aliguori@...ux.vnet.ibm.com>
To:	Cong Wang <amwang@...hat.com>
CC:	Rusty Russell <rusty@...tcorp.com.au>,
	linux-kernel@...r.kernel.org,
	Stephen Hemminger <shemminger@...tta.com>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	Anthony Liguori <aliguori@...ibm.com>,
	Jamie Lokier <jamie@...reable.org>,
	Thomas Weber <swirl@....li>,
	Ben Hutchings <ben@...adent.org.uk>,
	David Woodhouse <David.Woodhouse@...el.com>,
	Andy Fleming <afleming@...escale.com>,
	"David S. Miller" <davem@...emloft.net>,
	Neil Horman <nhorman@...hat.com>
Subject: Re: [RFC Patch] virtio: export model and type in /sys

On 01/30/2011 11:45 PM, Cong Wang wrote:
> (Adding Neil into Cc.)
>
> 于 2011年01月31日 12:05, Rusty Russell 写道:
>> On Mon, 31 Jan 2011 01:23:00 pm Amerigo Wang wrote:
>>> Our kdump script needs /sys/block/X/device/{vendor, model, type},
>>> but virtio devices don't have {model, type}, this patch adds them.
>>> Actually, I don't know how to fill the model field, other block devices
>>> seem read it from SCSI. Any comments?
>>
>> This seems deeply wrong.  Can't you fix your script?
>
> Well, we use (vendor, model, type) to identify a disk, and so far we only
> see virtio devices don't have this. So, we hope virtio at least provides
> some dummy files for us.

Uniquely identify the disk or identify the class of disk?

If it's the former, would serial be a better attribute to key off of?

Regards,

Anthony Liguori

>>
>> Model might sanely map to the feature bits, but making the type the same
>> as the PCI type is weird...
>>
>
> Yeah, that is why I mark the patch as RFC, I don't know which is the 
> correct way
> to fill these two values. Providing some dummy values is also fine for 
> us.
>
> Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/