linux-kernel - Re: Fwd: [PATCH] bq27x00_battery: Add new properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 31 Jan 2011 20:35:47 +0100
From:	Pali Rohár <pali.rohar@...il.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Lars-Peter Clausen <lars@...afoo.de>,
	Anton Vorontsov <cbouatmailru@...il.com>,
	Grazvydas Ignotas <notasas@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: Fwd: [PATCH] bq27x00_battery: Add new properties

2011/1/31 Mark Brown <broonie@...nsource.wolfsonmicro.com>:
> On Mon, Jan 31, 2011 at 08:19:30PM +0100, Lars-Peter Clausen wrote:
>> On 01/31/2011 07:07 PM, Pali Roh??r wrote:
>> > 2011/1/31 Anton Vorontsov <cbouatmailru@...il.com>:
>> >> On Mon, Jan 31, 2011 at 04:43:56PM +0100, Rodolfo Giometti wrote:
>
>> >>>> +MODULE_ALIAS("i2c:bq27000");
>> >>>> +MODULE_ALIAS("i2c:bq27200");
>> >>>> +MODULE_ALIAS("i2c:bq27500");
>
>> >> Btw, this is actually another bugfix. Pali, you might want to separate
>> >> it into yet another patch.
>
>> > Ok, I separate aliases to new patch.
>
>> The bq27000 is not an I2C device.
>
> Also, even if it were an I2C device this isn't how I2C devices get their
> module loading information set up - they use MODULE_DEVICE_TABLE().
>

If bq27000 is not I2C device it will remove line. My patch was primary
for Nokia N900 - RX51 board and it has battery bq27200 which is i2c
device. For autoloading this module I used MODULE_ALIAS("i2c:bq27200")
which works fine. Aliases was used in other i2c modules for Nokia N900
too.

Can you give me example how to use MODULE_DEVICE_TABLE (if alias is
not good solution)?

-- 
Pali Rohár
pali.rohar@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/