linux-kernel - Re: [PATCH] Staging: tm6000: fixed some coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 1 Feb 2011 13:23:59 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	Timo von Holtz <tvh@...ormatik.uni-kiel.de>
Cc:	gregkh@...e.de, mchehab@...hat.com, d.belimov@...il.com,
	stefan.ringel@...or.de, michel.ludwig@...il.com,
	c.pascoe@...e.uq.edu.au, ruslan@...sarev.org.ua,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: tm6000: fixed some coding style issues

Hi Timo,

On Tue,  1 Feb 2011 12:22:21 +0100, Timo von Holtz wrote:
> Fixed all of the following coding style issues:
> 
> ERROR: return is not a function, parentheses are not required
> WARNING: __func__ should be used instead of gcc specific __FUNCTION__

You messed up and replaced with __func instead of __func__.

> ERROR: trailing whitespace
> ERROR: spaces required around that '=' (ctx:VxV)
> WARNING: please, no space before tabs
> WARNING: please, no spaces at the start of a line
> ERROR: space required after that ',' (ctx:VxV)
> WARNING: space prohibited between function name and open parenthesis '('
> ERROR: spaces required around that '<' (ctx:VxV)
> ERROR: spaces required around that '==' (ctx:VxV)
> 
> Signed-off-by: Timo von Holtz <tvh@...ormatik.uni-kiel.de>
> ---
>  drivers/staging/tm6000/tm6000-alsa.c     |    6 +++---
>  drivers/staging/tm6000/tm6000-core.c     |    4 ++--
>  drivers/staging/tm6000/tm6000-dvb.c      |   10 +++++-----
>  drivers/staging/tm6000/tm6000-i2c.c      |    2 +-
>  drivers/staging/tm6000/tm6000-regs.h     |    2 +-
>  drivers/staging/tm6000/tm6000-usb-isoc.h |    2 +-
>  drivers/staging/tm6000/tm6000-video.c    |   28 ++++++++++++++--------------
>  drivers/staging/tm6000/tm6000.h          |    4 ++--
>  8 files changed, 29 insertions(+), 29 deletions(-)
> (...)
> --- a/drivers/staging/tm6000/tm6000-usb-isoc.h
> +++ b/drivers/staging/tm6000/tm6000-usb-isoc.h
> @@ -46,5 +46,5 @@ struct usb_isoc_ctl {
>  	int				tmp_buf_len;
>  
>  		/* Stores already requested buffers */
> -	struct tm6000_buffer    	*buf;
> +	struct tm6000_buffer	*buf;

You want one more tab to keep the struct elements aligned.

Other than that, this patch looks mostly good.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/