linux-kernel - Re: [RFC v2 PATCH 4/7] input: pmic8058

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 02 Feb 2011 13:13:23 +0530
From:	Trilok Soni <tsoni@...eaurora.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	Anirudh Ghayal <aghayal@...eaurora.org>,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	rtc-linux@...glegroups.com, linux-arm-msm@...r.kernel.org
Subject: Re: [RFC v2 PATCH 4/7] input: pmic8058_pwrkey: Add support for power
 key

Hi Dmitry,

On 2/1/2011 11:19 PM, Dmitry Torokhov wrote:
> On Tue, Feb 01, 2011 at 07:17:40PM +0530, Anirudh Ghayal wrote:
>> From: Trilok Soni <tsoni@...eaurora.org>
>>
>> Add support for PMIC8058 power key driven over dedicated
>> KYPD_PWR_N pin. It allows the user to specify the amount
>> of time by which the power key reporting can be delayed.
>>
>> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
>> Signed-off-by: Trilok Soni <tsoni@...eaurora.org>
>> ---
>> Changes from v1:
>> Addressed review comments from Dmitry.
>> Added KEY_SCREENLOCK instead of KEY_END.
> 
> ...
>> +	input_report_key(pwrkey->pwr, KEY_SCROLLLOCK, 1);
> ...
>> +	input_report_key(pwrkey->pwr, KEY_SCREENLOCK, 0);
> ...
>> +	input_set_capability(pwr, EV_KEY, KEY_SCROLLLOCK);
> 
> 
> You are confused about the event you are sending.

My mistake. I will fix this to KEY_SCREENLOCK in v3.

---Trilok Soni

-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/