linux-kernel - Re: [PATCH] [128/139] mac80211: fix mesh forwarding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 02 Feb 2011 08:56:14 +0100
From:	Johannes Berg <johannes.berg@...el.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	"javier@...ybit.com" <javier@...ybit.com>,
	"linville@...driver.com" <linville@...driver.com>,
	"gregkh@...e.de" <gregkh@...e.de>,
	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...nel.org" <stable@...nel.org>
Subject: Re: [PATCH] [128/139] mac80211: fix mesh forwarding

On Wed, 2011-02-02 at 00:45 +0000, Andi Kleen wrote:

> -			if (!fwd_skb && net_ratelimit())
> +			if (!fwd_skb && net_ratelimit()) {
>  				printk(KERN_DEBUG "%s: failed to clone mesh frame\n",
>  						   sdata->name);
> +				goto out;
> +			}

The net_ratelimit() here cause an obvious bug that I missed and a patch
for that was submitted later -- you may want to pick that one up and/or
fold it in (commit 919bbad580445801c22ef6ccbe624551fee652bd).

johannes

--------------------------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland 
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052