[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 2 Feb 2011 10:53:58 +0100 (CET)
From: Thomas Gleixner <tglx@...utronix.de>
To: Richard Cochran <richardcochran@...il.com>
cc: LKML <linux-kernel@...r.kernel.org>,
John Stultz <john.stultz@...aro.org>,
Richard Cochran <richard.cochran@...cron.at>,
Ingo Molnar <mingo@...e.hu>,
Peter Zijlstra <peterz@...radead.org>
Subject: Re: [patch 18/28] posix-timers: Convert timer_delete() to
clockid_to_kclock()
On Wed, 2 Feb 2011, Richard Cochran wrote:
> On Tue, Feb 01, 2011 at 01:52:07PM -0000, Thomas Gleixner wrote:
> > Index: linux-2.6-tip/kernel/posix-timers.c
> > ===================================================================
> > --- linux-2.6-tip.orig/kernel/posix-timers.c
> > +++ linux-2.6-tip/kernel/posix-timers.c
> > @@ -254,6 +254,7 @@ static __init int init_posix_timers(void
> > .timer_create = common_timer_create,
> > .timer_set = common_timer_set,
> > .timer_get = common_timer_get,
> > + .timer_del = common_timer_del,
> > };
> > struct k_clock clock_monotonic = {
> > .clock_getres = hrtimer_get_res,
> > @@ -263,6 +264,7 @@ static __init int init_posix_timers(void
> > .timer_create = common_timer_create,
> > .timer_set = common_timer_set,
> > .timer_get = common_timer_get,
> > + .timer_del = common_timer_del,
> > };
> > struct k_clock clock_monotonic_raw = {
> > .clock_getres = hrtimer_get_res,
>
> The definition of common_timer_del() should not be "inline" since the
> address of the function is in these tables. The declaration is not
> inline, and gcc 4.2.4 gives a warning.
>
> (But strangly, newer versions do not).
Will fix. Thanks.
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists