linux-kernel - Re: [PATCH] spi: spidev: Add 32 bit compat ioctl()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 02 Feb 2011 11:56:56 +0100
From:	Bernhard Walle <walle@...science.de>
To:	Arnd Bergmann <arnd@...db.de>
CC:	Grant Likely <grant.likely@...retlab.ca>,
	dbrownell@...rs.sourceforge.net,
	spi-devel-general@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] spi: spidev: Add 32 bit compat ioctl()

Am 02.02.2011 10:37, schrieb Arnd Bergmann:
> On Wednesday 02 February 2011, Grant Likely wrote:
>> On Tue, Feb 01, 2011 at 10:02:46AM +0100, Bernhard Walle wrote:
>>> Add the compat_ioctl for operations on /dev/spi* so that 32 bit
>>> userspace applications can access SPI. As far as I can see all data
>>> structure are already prepared for that, so no additional conversion has
>>> to be done.
>>>
>>> My use case is MIPS with N32 userspace ABI and toolchain, and that was
>>> also the platform where I tested it successfully (Cavium Octeon).
>>>
>>> Signed-off-by: Bernhard Walle <walle@...science.de>
>>
>> Arnd, can you please give your opinion on this one?  I haven't fully
>> got my head around the subtleties of 32/64 bit file_operations.
> 
> The patch is correct on everything except s390, which does not have SPI.
> The only thing that is missing for s390 is a pointer conversion of the ioctl
> argument, like:
> 
> static long     
> compat_spidev_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> {
> 	return spidev_ioctl(filp, cmd, (unsigned long)compat_ptr(arg));
> }

Thanks for the input. I modified my patch and sent it again.


Regards,
Bernhard


Download attachment "signature.asc" of type "application/pgp-signature" (901 bytes)