[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 02 Feb 2011 11:56:55 -0800
From: "H. Peter Anvin" <hpa@...or.com>
To: Gleb Natapov <gleb@...hat.com>
CC: linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>, x86@...nel.org
Subject: Re: [PATCH] Fix EDD3.0 data verification.
On 02/02/2011 09:59 AM, Gleb Natapov wrote:
>
> Ah I see what length you were referring to params->device_path_info_length.
> If we will use that then we will get correct checksum for BIOSes that work
> according to phoenix spec too, but edd_show_interface() and edd_show_host_bus()
> handle only T13 spec so the information they show can be incorrect. I can
> change code to check that params->device_path_info_length == 44 in addition
> to checking csum. What do you think?
>
Yes, you need to check both.
This is really a union of two similar-but-not-identical structures
distinguished by the length field.
-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists