lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 4 Feb 2011 16:08:46 +0100 From: Tejun Heo <tj@...nel.org> To: Vivek Goyal <vgoyal@...hat.com> Cc: Jens Axboe <jaxboe@...ionio.com>, Mike Snitzer <snitzer@...hat.com>, "tytso@....edu" <tytso@....edu>, "djwong@...ibm.com" <djwong@...ibm.com>, "shli@...nel.org" <shli@...nel.org>, "neilb@...e.de" <neilb@...e.de>, "adilger.kernel@...ger.ca" <adilger.kernel@...ger.ca>, "jack@...e.cz" <jack@...e.cz>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "kmannth@...ibm.com" <kmannth@...ibm.com>, "cmm@...ibm.com" <cmm@...ibm.com>, "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>, "rwheeler@...hat.com" <rwheeler@...hat.com>, "hch@....de" <hch@....de>, "josef@...hat.com" <josef@...hat.com>, "jmoyer@...hat.com" <jmoyer@...hat.com> Subject: Re: [PATCH v3 1/2] block: skip elevator data initialization for flush requests Hello, On Fri, Feb 04, 2011 at 10:04:57AM -0500, Vivek Goyal wrote: > > The rationale behind suggesting was that it indicates to the allocator > > that the request may be sorted as how the request will be used is > > communicated using @rw_flags to the allocator. The patch is buggy > > that the flag actually ends up on the request. Any better idea how to > > communicate it? > > Though you did not like the V1 of patch, personally I also liked just parsing > FLUSH or FUA flag in get_request(). > > Or how about intoducing a helper function blk_rq_should_init_elevator() > or something like that and this function will parse FLUSH, FUA flags. I suppose it's Jens' call, but if the FLUSH/FUA testing goes inside the alloc function, please decorate with big fat comment and mention it in the comment for the union definition too. Thank you. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists