linux-kernel - [PATCH 1/1] x86, apic: Make "broken BIOS!!" messages unique

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 4 Feb 2011 12:48:39 -0500
From:	John Villalovos <jvillalo@...hat.com>
To:	linux-kernel@...r.kernel.org
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Yinghai Lu <yinghai@...nel.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"John L. Villalovos" <john.l.villalovos@...el.com>,
	prarit@...hat.com
Subject: [PATCH 1/1] x86, apic: Make "broken BIOS!!" messages unique

x86, apic: Make "broken BIOS!!" messages unique

There are five identical "broken BIOS!!" messages.  This patch makes each
message unique so that it is easier to determine which message was actually
printed.

The 'inconceivable' messages are because it should not be possible to reach
those code paths.

Signed-off-by: John L. Villalovos <john.l.villalovos@...el.com>

diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 697dc34..b0c40c3 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -841,7 +841,7 @@ static int MPBIOS_polarity(int idx)
 		}
 		case 2: /* reserved */
 		{
-			printk(KERN_WARNING "broken BIOS!!\n");
+			printk(KERN_WARNING "broken BIOS: polarity!!\n");
 			polarity = 1;
 			break;
 		}
@@ -852,7 +852,7 @@ static int MPBIOS_polarity(int idx)
 		}
 		default: /* invalid */
 		{
-			printk(KERN_WARNING "broken BIOS!!\n");
+			printk(KERN_WARNING "broken BIOS: inconceivable polarity!!\n");
 			polarity = 1;
 			break;
 		}
@@ -899,7 +899,7 @@ static int MPBIOS_trigger(int idx)
 				}
 				default:
 				{
-					printk(KERN_WARNING "broken BIOS!!\n");
+					printk(KERN_WARNING "broken BIOS: unknown bus type!!\n");
 					trigger = 1;
 					break;
 				}
@@ -913,7 +913,7 @@ static int MPBIOS_trigger(int idx)
 		}
 		case 2: /* reserved */
 		{
-			printk(KERN_WARNING "broken BIOS!!\n");
+			printk(KERN_WARNING "broken BIOS: trigger!!\n");
 			trigger = 1;
 			break;
 		}
@@ -924,7 +924,7 @@ static int MPBIOS_trigger(int idx)
 		}
 		default: /* invalid */
 		{
-			printk(KERN_WARNING "broken BIOS!!\n");
+			printk(KERN_WARNING "broken BIOS: inconceivable trigger!!\n");
 			trigger = 0;
 			break;
 		}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/