linux-kernel - Re: [PATCH 6/8]staging: brcm80211i: sbsdio.h: change a typo comamnd to command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 4 Feb 2011 13:13:17 -0800
From:	Justin Mattock <justinmattock@...il.com>
To:	Greg KH <greg@...ah.com>
Cc:	trivial@...nel.org, henryp@...adcom.com, gregkh@...e.de,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/8]staging: brcm80211i: sbsdio.h: change a typo comamnd to command


On Feb 4, 2011, at 1:00 PM, Greg KH wrote:

> On Fri, Feb 04, 2011 at 12:59:19PM -0800, Greg KH wrote:
>> On Tue, Feb 01, 2011 at 09:07:28PM -0800, Justin P. Mattock wrote:
>>> The below patch fixes a typo comamnd to command.
>>>
>>> Signed-off-by: Justin P. Mattock <justinmattock@...il.com>
>>>
>>> ---
>>> drivers/staging/brcm80211/include/sbsdio.h |    2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/staging/brcm80211/include/sbsdio.h b/drivers/ 
>>> staging/brcm80211/include/sbsdio.h
>>> index 6afdbbe..c190acb 100644
>>> --- a/drivers/staging/brcm80211/include/sbsdio.h
>>> +++ b/drivers/staging/brcm80211/include/sbsdio.h
>>> @@ -144,7 +144,7 @@
>>> 						 */
>>>
>>> #define SBSDIO_BYTEMODE_DATALEN_MAX	64	/* sdio byte mode: maximum  
>>> length of one
>>> -						 * data comamnd
>>> +						 * data command
>>
>> This patch adds a trailing space, which is not allowed.
>>
>> Please fix this and resend.
>
> Nevermind, I've edited this by hand and fixed it up.
>
> Please be more careful in the future and ALWAYS run your patches  
> through
> scripts/checkpatch.pl to catch these types of things.
>
> thanks,
>
> greg k-h


yep I admit I had forgotten to use that script(was focusing on  
maintainers)..
I will remember that next time..

Thanks..

Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/