linux-kernel - Re: [PATCH V1 3/3] drivers/staging: kztmem: misc build/config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 4 Feb 2011 13:28:43 -0800
From:	Greg KH <greg@...ah.com>
To:	Dan Magenheimer <dan.magenheimer@...cle.com>
Cc:	gregkh@...e.de, chris.mason@...cle.com, akpm@...ux-foundation.org,
	torvalds@...ux-foundation.org, matthew@....cx,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	ngupta@...are.org, jeremy@...p.org, kurt.hackel@...cle.com,
	npiggin@...nel.dk, riel@...hat.com, konrad.wilk@...cle.com,
	mel@....ul.ie, minchan.kim@...il.com,
	kosaki.motohiro@...fujitsu.com, sfr@...b.auug.org.au,
	wfg@...l.ustc.edu.cn, tytso@....edu, viro@...IV.linux.org.uk,
	hughd@...gle.com, hannes@...xchg.org
Subject: Re: [PATCH V1 3/3] drivers/staging: kztmem: misc build/config

On Tue, Jan 18, 2011 at 09:21:51AM -0800, Dan Magenheimer wrote:
> [PATCH V1 3/3] drivers/staging: kztmem: misc build/config
> 
> Makefiles and Kconfigs to build kztmem in drivers/staging
> 
> There is a dependency on xvmalloc.* which in 2.6.37 resides
> in drivers/staging/zram.  Should this move or disappear,
> some Makefile/Kconfig changes will be required.

There is some other kind of dependancy as well, because I get the
following errors when building:

drivers/staging/kztmem/kztmem.c:34:2: error: #error "kztmem is useless without CONFIG_CLEANCACHE or CONFIG_FRONTSWAP"
drivers/staging/kztmem/kztmem.c:531:13: warning: ‘zbud_init’ defined but not used
drivers/staging/kztmem/kztmem.c:883:28: warning: ‘kztmem_hostops’ defined but not used
drivers/staging/kztmem/kztmem.c:988:27: warning: ‘kztmem_pamops’ defined but not used
drivers/staging/kztmem/kztmem.c:1063:30: warning: ‘kztmem_cpu_notifier_block’ defined but not used
drivers/staging/kztmem/kztmem.c:1201:24: warning: ‘kztmem_shrinker’ defined but not used
drivers/staging/kztmem/kztmem.c:1210:12: warning: ‘kztmem_put_page’ defined but not used
drivers/staging/kztmem/kztmem.c:1242:12: warning: ‘kztmem_get_page’ defined but not used
drivers/staging/kztmem/kztmem.c:1259:12: warning: ‘kztmem_flush_page’ defined but not used
drivers/staging/kztmem/kztmem.c:1278:12: warning: ‘kztmem_flush_object’ defined but not used
drivers/staging/kztmem/kztmem.c:1297:12: warning: ‘kztmem_destroy_pool’ defined but not used
drivers/staging/kztmem/kztmem.c:1320:12: warning: ‘kztmem_new_pool’ defined but not used
drivers/staging/kztmem/kztmem.c:1558:19: warning: ‘enable_kztmem’ defined but not used
drivers/staging/kztmem/kztmem.c:1569:19: warning: ‘no_cleancache’ defined but not used
drivers/staging/kztmem/kztmem.c:1579:19: warning: ‘no_frontswap’ defined but not used

If you require a kbuild dependancy, then put it in your Kconfig file
please, don't break the build.

I'll not apply these patches for now until that's fixed up.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/