linux-kernel - Re: Sun GEM PPC32 Bug?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 06 Feb 2011 10:45:49 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	"R. Herbst" <ruediger.herbst@...glemail.com>
Cc:	linux-kernel@...r.kernel.org, David Miller <davem@...emloft.net>,
	Matt <jackdachef@...il.com>, geert@...ux-m68k.org
Subject: Re: Sun GEM PPC32 Bug?


> If I find some time tonight, else tomorrow, I'll whip up a couple of
> patches:
> 
>  - One simpler re-arranging our Rx reset sequence and adding a test for
> the overflow bit at the end, printing out the results, etc... 
> 
>  - One that basically always reset the chip on overflow.

Actually, the second one is trivial, just modify gem_rxmac_interrupt()
as follow:

	if (rxmac_stat & MAC_RXSTAT_OFLW) {
		u32 smac = readl(gp->regs + MAC_SMACHINE);

		netdev_err(dev, "RX MAC fifo overflow smac[%08x]\n", smac);
		gp->net_stats.rx_over_errors++;
		gp->net_stats.rx_fifo_errors++;

-		ret = gem_rxmac_reset(gp);
+		ret = 1;
	}

And tell us if that makes a difference.

Cheers,
Ben.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/