linux-kernel - Re: [BUG] usb_set_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 6 Feb 2011 22:01:51 +0900
From:	Minchan Kim <minchan.kim@...il.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	linux kernel mailing list <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [BUG] usb_set_device_state

On Sun, Feb 6, 2011 at 9:03 PM, Rafael J. Wysocki <rjw@...k.pl> wrote:
> On Sunday, February 06, 2011, Rafael J. Wysocki wrote:
>> On Sunday, February 06, 2011, Alan Stern wrote:
>> > On Sun, 6 Feb 2011, Rafael J. Wysocki wrote:
>> >
>> > > On Saturday, February 05, 2011, Alan Stern wrote:
>> > > > On Sun, 6 Feb 2011, Minchan Kim wrote:
>> > > >
>> > > > > I got following message during booting mmotm-02-04.
>> > ...
>> > > > > It seems usb_set_device_state disable irq by spin_lock_irqsave.
>> > > > > But it calls device_set_wakeup_capable which ends up calling sysfs_merge_group.
>> > > > > It calls mutex_lock. :(
>> > > > >
>> > > > > Is it already known BUG?
>> > > >
>> > > > No, it was newly introduced by changes to the
>> > > > device_set_wakeup_capable() routine.  Rafael, this sort of problem may
>> > > > occur in other places too, since previously there was no requirement
>> > > > that device_set_wakeup_capable() be called in process context.
>> > >
>> > > I'm aware of that, but it's only happend in a handful of network drivers so far.
>> > >
>> > > I think this is a new case in -mm, though, isn't it?
>> >
>> > I'm not sure.  The USB core does call device_set_wakeup_capable()
>> > while holding one or more spinlocks in usb_set_device_state(), and that
>> > routine is called in several places.  You ought to be able to duplicate
>> > the error on your own system simply by plugging in a USB hub.
>>
>> No, I'm not.  At least not with 2.6.37.
>>
>> Also, I think the problem would have been reported before if it had been that
>> easy to reproduce with the mainline kernel.
>
> Or do I need to enable a specific CONFIG_ option to reproduce it?
>
> Rafael
>

When I am googling, I found https://lkml.org/lkml/2011/1/14/440.
Maybe the bug is caused by that.
It is in linux-next and mmotm, not linus tree.



-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/