lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 6 Feb 2011 23:05:57 +0000 From: Chris Ball <cjb@...top.org> To: Andres Salomon <dilinger@...ued.net> Cc: Greg KH <gregkh@...e.de>, Marek Belisko <marek.belisko@...n-nandra.com>, jon.nettleton@...il.com, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] olpc_dcon: revert strtoul change Hi, On Sun, Feb 06, 2011 at 02:38:16PM -0800, Andres Salomon wrote: > The s/simple_strtoul/strict_strtoul/ from commit e107e6eb added a build > warning, as well as an oops. This reverts that change. > > Signed-off-by: Andres Salomon <dilinger@...ued.net> > --- > drivers/staging/olpc_dcon/olpc_dcon.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c > index b19cd34..d6ad5d7 100644 > --- a/drivers/staging/olpc_dcon/olpc_dcon.c > +++ b/drivers/staging/olpc_dcon/olpc_dcon.c > @@ -525,7 +525,7 @@ static int _strtoul(const char *buf, int len, unsigned int *val) > { > > char *endp; > - unsigned int output = strict_strtoul(buf, &endp, 0); > + unsigned int output = simple_strtoul(buf, &endp, 0); > int size = endp - buf; > > if (*endp && isspace(*endp)) Yes, different prototypes: unsigned long simple_strtoul(const char *cp, char **endp, unsigned int base) vs. int strict_strtoul(const char *cp, unsigned int base, unsigned long *res) So, you'd need something like: unsigned int output; int ret = strict_strtoul(buf, 0, &output); if (ret < 0) return ret; -- Chris Ball <cjb@...top.org> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists